-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serial part 1.0.0 renaming #186
Serial part 1.0.0 renaming #186
Conversation
* improved naming for catenaX ID elements * fixed some encoding issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add release notes and check comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add release notes and check comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SAMM meta model will be changed to BAMM 2.0.0 |
Validation Report for io.catenax.serial_part/1.0.0/SerialPart.ttlInput model is valid |
I think the Characteristic of ManufacutringCharateristic should be "SingleEntity" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We want to create a new model named SerialPartAsBuilt which will replace the existing model SerialPartTypization. The reason for the replacement is to match our naming convention from BomAsPlanned and other BoMs.
Closes #79
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)